Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial inplayer subscription change implementation #320

Merged
merged 25 commits into from
Jul 26, 2023

Conversation

naumovski-filip
Copy link
Contributor

@naumovski-filip naumovski-filip commented Jun 19, 2023

Description

Testing config: 7jh8ypyh

@naumovski-filip naumovski-filip self-assigned this Jun 19, 2023
@naumovski-filip naumovski-filip changed the title feat: initial inplayer subscription change implementation [WIP] feat: initial inplayer subscription change implementation Jun 20, 2023
@naumovski-filip naumovski-filip marked this pull request as ready for review June 20, 2023 09:34
@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Visit the preview URL for this PR (updated for commit 19cd475):

https://ottwebapp--pr320-feat-change-subscrip-zzerp5pp.web.app

(expires Wed, 23 Aug 2023 14:30:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@naumovski-filip naumovski-filip removed the request for review from MelissaDTH June 27, 2023 10:46
Copy link
Collaborator

@darkoatanasovski darkoatanasovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the Figma designs, cancel subscription button should be visible only when the change plan view is active.

@darkoatanasovski darkoatanasovski self-requested a review July 21, 2023 09:43
@naumovski-filip naumovski-filip dismissed darkoatanasovski’s stale review July 21, 2023 09:47

requested changes have been resolved

@kiremitrov123 kiremitrov123 changed the title [WIP] feat: initial inplayer subscription change implementation feat: initial inplayer subscription change implementation Jul 25, 2023
@kiremitrov123 kiremitrov123 merged commit d8b6988 into develop Jul 26, 2023
9 checks passed
@kiremitrov123 kiremitrov123 deleted the feat/change-subscription branch July 26, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants