Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): remove github pages #324

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Conversation

AntonLantukh
Copy link
Collaborator

Description

Remove github pages

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@github-actions
Copy link

github-actions bot commented Jun 28, 2023

Visit the preview URL for this PR (updated for commit 0906947):

https://ottwebapp--pr324-feat-remove-github-p-bkfx3i3o.web.app

(expires Fri, 04 Aug 2023 08:15:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@AntonLantukh AntonLantukh marked this pull request as ready for review June 28, 2023 09:30
Copy link
Contributor

@dbudzins dbudzins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love a PR that removes so much boilerplate. We can probably even remove the hash routing functionality too. What do you think?

@AntonLantukh AntonLantukh merged commit 0f07d0d into develop Jul 5, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants