Feat / profiles loading overlay #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a0f8598): https://ottwebapp--pr338-feat-profiles-loader-epq2wf4h.web.app (expires Sun, 13 Aug 2023 12:13:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the LoadingOverlay component so it can be reused in the profiles section.
-Added new parameter in the LoadingOverlay component
profileImageUrlwhich if it's present, an avatar image from the specified profile is rendered inside the loader.-Added new variant to the Spinner component
largewhich is only used whenprofileImageUrlparameter is applied (also additional styling is applied).Steps completed:
According to our definition of done, I have completed the following steps: