Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: selecting profiles #341

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

borkopetrovicc
Copy link
Contributor

Description

https://www.figma.com/file/qLl8KxBOOr640h18ICx0H6/Web-app?type=design&node-id=2344-62791&mode=design&t=Ph6Hfz6Pr7AtyUbw-0

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@github-actions
Copy link

github-actions bot commented Jul 16, 2023

Visit the preview URL for this PR (updated for commit 4bb76f0):

https://ottwebapp--pr341-feat-selecting-profi-ijk82k20.web.app

(expires Thu, 17 Aug 2023 15:43:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, I see that none of the texts are translated. Is this on your to-do list?

@borkopetrovicc
Copy link
Contributor Author

I left a few comments, I see that none of the texts are translated. Is this on your to-do list?

Yes it is on my to-do list.

@dbudzins
Copy link
Contributor

I left a few comments, I see that none of the texts are translated. Is this on your to-do list?

Yes it is on my to-do list.

You can create a PR in draft status if you are still finishing up things like this, and then reviewers won't automatically get notified.

@naumovski-filip naumovski-filip merged commit e4963b9 into feat/profiles Jul 19, 2023
4 of 6 checks passed
@naumovski-filip naumovski-filip deleted the feat/selecting-profiles branch July 19, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants