chore(project): add anchor tags for better seo #345
Conversation
|
Visit the preview URL for this PR (updated for commit b6c6df5): https://ottwebapp--pr345-chore-seo-add-anchor-4rtiv4wy.web.app (expires Fri, 01 Sep 2023 14:53:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
src/components/Shelf/Shelf.tsx
Outdated
| posterAspect={posterAspect} | ||
| item={item} | ||
| /> | ||
| <a href={isInView ? url : undefined} className={styles.cardWrapper}> |
There was a problem hiding this comment.
I think it is better to update the Card component because now it results in a button wrapped by an anchor tag. This negatively impacts the accessibility for keyboard/screenreader users. Besides that, the Card component is also used on the playlist screens, which use the CardGrid component.
Current HTML
<a href="/m/uB8aRnu6/agent-327?r=dGSUzs9o" class="_cardWrapper_1ge8j_66">
<div class="_card_1lln7_1" tabindex="0" role="button" aria-label="Play Agent 327">Expected HTML
<a href="/m/uB8aRnu6/agent-327?r=dGSUzs9o" class="_card_1lln7_1" aria-label="Agent 327">I also see that the aria-label contains the prefix "Play " which can be removed.
There was a problem hiding this comment.
Hey Chris, thanks! I've discussed that with Danny, and I am indeed moving the tag inside of the Card component.
src/pages/ScreenRouting/playlistScreens/PlaylistGrid/PlaylistGrid.tsx
Outdated
Show resolved
Hide resolved
src/pages/ScreenRouting/mediaScreens/MediaSeries/MediaSeries.tsx
Outdated
Show resolved
Hide resolved
src/pages/ScreenRouting/playlistScreens/PlaylistLiveChannels/PlaylistLiveChannels.tsx
Outdated
Show resolved
Hide resolved
Description
OWA-6
This PR solves # .
Steps completed:
Add tag inside Shelf.tsx
Remove onCardClick() from Shelflist.tsx
According to our definition of done, I have completed the following steps: