Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom register fields: Implement translation for Country and US State lists #348

Merged

Conversation

mirovladimitrovski
Copy link
Collaborator

Description

Country and US State lists have previously been implemented as static lists of country/state names in English.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Visit the preview URL for this PR (updated for commit f04af0e):

https://ottwebapp--pr348-feat-crf-translatabl-5o294aso.web.app

(expires Wed, 30 Aug 2023 11:42:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@dbudzins
Copy link
Contributor

Did you just add the translations directly from English? This is something that is relatively easily searchable:

https://www.language-pro.info/names-of-the-u-s-states-in-spanish/
https://www.blablalang.com/countries-nationalities-spanish/

Or just leave them blank so we know they need to be properly filled in.

@mirovladimitrovski mirovladimitrovski merged commit a5040a9 into feat/custom-reg-fields Jul 31, 2023
7 checks passed
@mirovladimitrovski mirovladimitrovski deleted the feat/crf-translatable-lists branch July 31, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants