Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): support translations for shelves titles and menu labels #612

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

CarinaDraganJW
Copy link
Contributor

Description

  • PR proposal for implementing translations for shelves titles and menu labels

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@CarinaDraganJW CarinaDraganJW added the forming This idea is a brainstorm, green field, or work in progress label Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

Visit the preview URL for this PR (updated for commit 01d5276):

https://ottwebapp--pr612-feature-support-tran-0w9k10w5.web.app

(expires Wed, 30 Oct 2024 07:18:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forming This idea is a brainstorm, green field, or work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants