Drop use of base64 gem and warn about invalid base64 input #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the dependency to the base64 gem. Motivation for this is the warnings emitting if
base64
is not in the Gemfile/gemspec of the component running it, this is something that is a thing in Ruby 3.3 forward(ref). Another approach would be to list base64 as a dependency to in the .gemspec, but I kinda like the control of the Base64 handling. Maybe in the future we can remove the custom logic.A bit of base64 history:
#483
#551
This approach also allows nicer way to deprecate support for the looser base64 that is baked into RFC 2045
Checklist
Before the PR can be merged be sure the following are checked: