Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of base64 gem and warn about invalid base64 input #578

Closed
wants to merge 1 commit into from

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Dec 28, 2023

Description

This pull request removes the dependency to the base64 gem. Motivation for this is the warnings emitting if base64 is not in the Gemfile/gemspec of the component running it, this is something that is a thing in Ruby 3.3 forward(ref). Another approach would be to list base64 as a dependency to in the .gemspec, but I kinda like the control of the Base64 handling. Maybe in the future we can remove the custom logic.

A bit of base64 history:

#483
#551

This approach also allows nicer way to deprecate support for the looser base64 that is baked into RFC 2045

Checklist

Before the PR can be merged be sure the following are checked:

  • There are tests for the fix or feature added/changed
  • A description of the changes and a reference to the PR has been added to CHANGELOG.md. More details in the CONTRIBUTING.md

@anakinj anakinj force-pushed the drop-base64-dependency branch 3 times, most recently from 6dfc74f to e2792bf Compare December 30, 2023 19:48
@anakinj
Copy link
Member Author

anakinj commented Dec 30, 2023

I changed my mind. Think it's better to add the base64 gem as a dependency.

@anakinj anakinj closed this Dec 30, 2023
@anakinj anakinj mentioned this pull request Dec 30, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant