Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] [Install.Import] Allow adding multiple import statements #28

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

mateusfpleite
Copy link
Collaborator

@mateusfpleite mateusfpleite commented Jun 17, 2024

  • Changes Install.Import.init to receive a list of records of the type { moduleToImport : String, alias_ : Maybe String, exposedValues ​​: List String }.
  • Small tweak to checking to ensure duplicate imports won't prevent other imports from being installed.
  • Adjust documentation to reflect new API
  • Adjust previous tests to changes and create new tests

Closes #24.

@mateusfpleite mateusfpleite changed the title [Install.Import] Allow adding multiple import statements [Breaking change] [Install.Import] Allow adding multiple import statements Jun 17, 2024
@mateusfpleite
Copy link
Collaborator Author

@jxxcarlson I ended up making the changes to the init function itself instead of adding a new function to keep the module simple and maintain internal consistency, but I'm not sure if this made it less intuitive to use. What do you think?

@jxxcarlson
Copy link
Owner

Matteus, the new API is really nice. I added another option in the same style:

Install.Import.initSimple "Frontend" [ "Foo.Bar", "Baz.Qux" ]
        |> Install.Import.makeRule

@jxxcarlson jxxcarlson merged commit bed7467 into jxxcarlson:main Jun 18, 2024
2 of 3 checks passed
@mateusfpleite mateusfpleite deleted the feat/add-multiple-imports branch July 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Install.Import] Allow adding multiple import statements
2 participants