This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Fix Vector2 warning #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove precompileedHeader condition
idk but maybe work
kryr34
removed
help wanted
NOOBDY
reviewed
Apr 19, 2023
Source/Unity/Vector2.h
Outdated
There was a problem hiding this comment.
why not const Vector2<T>& other
There was a problem hiding this comment.
for Vector2<int> + Vector2<float>
There was a problem hiding this comment.
so this means the warning is valid and I don't think you should be doing type conversions in the function
There was a problem hiding this comment.
so I should do conversion before operation?
There was a problem hiding this comment.
I think would do it this way if I were writing this
* Set `Debug TreatWarningAsError` to `true`. * Make sure that Github Action builds using `Debug` mode instead of `Release` mode." * Condition of precompile
NOOBDY
reviewed
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TreatWarningAsErrorback totrue.warning C4244: 'argument': conversion from 'T' to 'T', possible loss of datain Vector2