Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct template when installing as a SystemV service #5044

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Use the correct template when installing as a SystemV service #5044

merged 7 commits into from
Sep 30, 2024

Commits on Sep 26, 2024

  1. Remove unused install.GetSysInit() function 

    There are no references to this function.

Signed-off-by: Kimmo Lehto <[email protected]>
    @kke
    kke committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ecab42f View commit details
    Browse the repository at this point in the history

  2. Remove unused darwin launchd integration 

    Since k0s does not run on mac, there's no need for launchd service
installer.

Signed-off-by: Kimmo Lehto <[email protected]>
    @kke
    kke committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2227665 View commit details
    Browse the repository at this point in the history

  3. Remove empty pkg/install/process.go 

    The file was empty except for the copyright header and package name.

Signed-off-by: Kimmo Lehto <[email protected]>
    @kke
    kke committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    96db2f6 View commit details
    Browse the repository at this point in the history

  4. Extract systemd template to pkg/install/linux_systemd.go 

    Unlike openrc, upstart and system v unit file templates, the systemd
template was defined in pkg/install/service.go. Here it is extracted
into a dedicated file like the other templates.

Signed-off-by: Kimmo Lehto <[email protected]>
    @kke
    kke committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    edaa054 View commit details
    Browse the repository at this point in the history

  5. Use SysVScript field for system v, not SystemdScript 

    The customized system V service template was not being used, as the
template was put into "SystemdScript" option. The correct option name
seems to be "SysVScript".

Signed-off-by: Kimmo Lehto <[email protected]>
    @kke
    kke committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    36b7bc2 View commit details
    Browse the repository at this point in the history

  6. Remove double "name" field from openrc script 

    The openrc unit file template had the "name=" definition twice. I assume
it is the last one that was effective.

Signed-off-by: Kimmo Lehto <[email protected]>
    @kke
    kke committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2a7e7ae View commit details
    Browse the repository at this point in the history

  7. Remove unused prepareEnvVars function 

    There are no references to this function. The linter catches is as
unused.

Signed-off-by: Kimmo Lehto <[email protected]>
    @kke
    kke committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    416c9ff View commit details
    Browse the repository at this point in the history