Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline manifestsSaver #5063

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Inline manifestsSaver #5063

wants to merge 6 commits into from

Commits on Oct 31, 2024

  1. Inline manifestsSaver into the CRD component 

    The manifestSaver abstraction was not serving any special purpose for
the CRDs. Inlining it makes the code more straightforward.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ae964ac View commit details
    Browse the repository at this point in the history

  2. Inline manifestsSaver into the KubeRouter component 

    Adjust the tests to use temporary directories and let them call all the
lifecycle methods.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    451b53d View commit details
    Browse the repository at this point in the history

  3. Inline manifestsSaver into the Windows stack component 

    The manifestSaver abstraction was not serving any special purpose.
Inlining it makes the code more straightforward.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    644bce6 View commit details
    Browse the repository at this point in the history

  4. Inline manifestsSaver into the Calico component 

    Adjust the tests to use temporary directories and let them call all the
lifecycle methods.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d862edd View commit details
    Browse the repository at this point in the history

  5. Inline manifestsSaver into the Metrics component 

    The manifestSaver abstraction was not serving any special purpose.
Inlining it makes the code more straightforward.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a3465ff View commit details
    Browse the repository at this point in the history

  6. Remove the now unused manifestsSaver 

    Its functionality has been inlined into the components.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ad3fd24 View commit details
    Browse the repository at this point in the history