Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix etcd peer URL to support ipv6 #5181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix etcd peer URL to support ipv6 #5181

wants to merge 1 commit into from
+19 −6

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Nov 5, 2024

IPv6 URL need to have brackets [] around the ipv6 to separate it from the port. Eg https://[xx:yy:zz]:2380

Fix this by using net/url's String() formatter.

Description

Fixes #5180

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ncopa
Fix etcd peer URL to support ipv6
1469e0c 
IPv6 URL need to have brackets [] around the ipv6 to separate it from
the port. Eg https://[xx:yy:zz]:2380

Fix this by using net/url's String() formatter.

Signed-off-by: Natanael Copa <[email protected]>
@ncopa ncopa requested review from a team as code owners November 5, 2024 13:34
@ncopa ncopa enabled auto-merge November 5, 2024 14:26
@ncopa ncopa added bug Something isn't working area/network component/etcd backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/network backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch backport/release-1.31 PR that needs to be backported/cherrypicked to the release-1.31 branch bug Something isn't working component/etcd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

etcd component does not support IPv6 only addresses
1 participant
@ncopa