Skip to content

[Backport release-1.32] Bump konnectivity to v0.32.0 #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-1.32
Choose a base branch
from

Conversation

makhov
Copy link
Contributor

@makhov makhov commented May 8, 2025

Backport #5741 to release-1.32

Signed-off-by: Tom Wieczorek <[email protected]>
(cherry picked from commit 7afaf79)
@makhov makhov requested review from a team as code owners May 8, 2025 08:33
@makhov makhov requested review from ncopa and kke May 8, 2025 08:33
@twz123
Copy link
Member

twz123 commented May 8, 2025

I'm wondering what might be the requirement to have this in v1.32? It's not a simple patch version bump.

@jnummelin
Copy link
Member

@twz123 There's two "drivers" for this.

First is the fact that 0.32 has the logging fixes @makhov contributed so now konnectivity is much less noisy. Some k0smotron users have been complaining about this.

Second is that the konnectivity versioning scheme says:

Releases and tags align with the Kubernetes minor release versions (the y in x.y.z). For instance, if Kubernetes releases version 1.99.0, the corresponding release and tag for apiserver-network-proxy will be 0.99.0.

IMO that means we should really use 0.32 for our Kube 1.32 branch

@twz123
Copy link
Member

twz123 commented May 13, 2025

Hmm, still not entirely convinced. The logging changes broke the k0s OS tests. I admit that you shouldn't count the log format as a stable API, but it's still quite an unexpected change for a point release, going from chatty to almost dead. If we really want to have the version parity between konnectivity and Kubernetes, I'd add a unit test for that, as we have for all the other version constraints, so this won't go unnoticed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants