-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert kubeconfig modification functionality changes #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
reviewed
Jun 11, 2024
kke
changed the title
Revert "k0sctl kubeconfig" changes made in #720
Revert kubeconfig modification functionality changes
Jun 12, 2024
Something's wrong with the runners. Need to retry later.
|
I guess we could merge this without going green since it's a different problem in the CI that is causing the failure. |
kke
force-pushed
the
revert-720
branch
4 times, most recently
from
June 26, 2024 12:54
0592980
to
830865a
Compare
Looks like the docker downgrade workaround makes this green. |
Going to try this without the docker downgrade once a fixed bootloose is baked. |
…#720)" This reverts commit 1afb01f. Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1afb01f from #720
The kubeconfig manipulation (address changes) is kept how it was before v0.18.0 but the reading of the kubeconfig is changed to use
k0s kubeconfig admin
instead of reading the file from datadir directly.