Use kubernetes URL from join token to validate node connectivity #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
force-pushed
the
validate-connection-externaladdress
branch
3 times, most recently
from
61068ae to
6a5d5c7
Compare
kke
changed the title
kke
changed the title
kke
changed the title
kke
force-pushed
the
validate-connection-externaladdress
branch
6 times, most recently
from
2e5425b to
8709a9d
Compare
Signed-off-by: Kimmo Lehto <[email protected]>
kke
force-pushed
the
validate-connection-externaladdress
branch
from
8709a9d to
6fb630f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798
The join token, once decoded, contains the kube (workers) or k0s (controllers) API URL that the node will use to communicate to the control plane.
Instead of trying to replicate the logic of k0s choosing which address to validate against, use the address (and certs) provided by k0s inside the token, because that is what the node will do.