Update signature of compare/diff built-in functions step by step #1052
+75
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
k1LoW
force-pushed
the
main
branch
2 times, most recently
from
d2e08c7
to
68d8c0f
Compare
BenchmarkManyRunbooks-4
Metadata
BenchmarkOpenAPI3-4
Metadata
BenchmarkSingleRunbook-4
Metadata
Reported by octocov |
Code Metrics Report
Details | | main (68d8c0f) | #1052 (f70567e) | +/- |
|---------------------|----------------|-----------------|--------|
- | Coverage | 64.4% | 64.4% | -0.1% |
| Files | 77 | 77 | 0 |
| Lines | 8666 | 8682 | +16 |
+ | Covered | 5589 | 5597 | +8 |
- | Code to Test Ratio | 1:0.7 | 1:0.7 | -0.1 |
| Code | 15941 | 15973 | +32 |
+ | Test | 11663 | 11664 | +1 |
- | Test Execution Time | - | 5m38s | +5m38s |Code coverage of files in pull request scope (75.7% → 75.4%)
Reported by octocov |
|
@k2tzumi |
k2tzumi
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
I have included below a comment expressing my feelings
#1047 (comment)
Comment on lines
+18
to
+20
| if len(ignores) > 1 { | ||
| deprecation.AddWarning("diff/compare", "diff/compare(x, y, ignores...string) is deprecated. Use diff/compare(x, y, ignores []string) instead.") | ||
| } |
There was a problem hiding this comment.
I understood that it would be phased out.
Comment on lines
+26
to
+33
| case []any: | ||
| for _, vv := range v { | ||
| s, ok := vv.(string) | ||
| if !ok { | ||
| return "", fmt.Errorf("invalid ignore specifiers: %v", vv) | ||
| } | ||
| ignoreSpecifiers = append(ignoreSpecifiers, s) | ||
| } |
There was a problem hiding this comment.
Currently accepting ANY for compatibility, so it needs to be checked.
| @@ -25,7 +52,7 @@ func Diff(x, y any, ignorePaths ...string) (string, error) { | |||
| return "", err | |||
| } | |||
|
|
|||
| jqIgnorePaths, cmpIgnoreKeys := impl.splitIgnoreSpecifiers(ignorePaths) | |||
| jqIgnorePaths, cmpIgnoreKeys := impl.splitIgnoreSpecifiers(ignoreSpecifiers) | |||
There was a problem hiding this comment.
This process will also be unnecessary in the future.
Comment on lines
+3
to
+9
| merge: | ||
| test: | | ||
| compare( | ||
| {"a": 1, "b": 3, "c": 5}, | ||
| {"a": 1, "b": 2, "c": 4}, | ||
| "b", "c" | ||
| ) |
There was a problem hiding this comment.
This test here will fail in the future.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1047
Because variadic arguments like Go cannot be used in expr-lang.
While accepting both arguments, deprecate the variadic argument type.