librispeech_decode : split save_results() -> save_asr_output() + save_wer_results()
#1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarelVesely84
changed the title
save_results() -> save_asr_output() + save_wer_results()save_results() -> save_asr_output() + save_wer_results()
- the idea is to support `--skip-scoring` argument passed to a decoding script - created for Transducer decoding (non-streaming, streaming) - it can be done also for CTC decoding... (not yet) - also added `--label` for extra label in `streaming_decode.py` - and also added `set_caching_enabled(True)`, which has no effect on librispeech, but it leads to faster runtime on DBs with long recordings (assuming `librispeech/zipformer` scripts are the example scripts for other setups) - still need to run the code to make sure it works properly - at this point, interested in getting early feedback from you... Thank you.
KarelVesely84
force-pushed
the
skip_scoring
branch
from
bc87117
to
7d3c521
Compare
KarelVesely84
changed the title
save_results() -> save_asr_output() + save_wer_results()save_results() -> save_asr_output() + save_wer_results()
KarelVesely84
changed the title
save_results() -> save_asr_output() + save_wer_results()save_results() -> save_asr_output() + save_wer_results()
|
Hi @csukuangfj , What should be the next step ? Best regards, |
|
Looks good to me. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THE IDEA
--skip-scoringargument passed to a decoding scriptOTHER CHANGES
--labelfor extra label instreaming_decode.pyset_caching_enabled(True)librispeech/zipformerscripts are the example scripts for other setups)TESTING
Thank you.