Fix omissions and errors in the reset role that leave artifacts after successful reset.yml playbook run #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-uninstall.sh, from https://get.k3s.io Signed-off-by: Jon S. Stumpf <[email protected]>
…les/reset can use it Signed-off-by: Jon S. Stumpf <[email protected]>
…et/tasks/main.yml Signed-off-by: Jon S. Stumpf <[email protected]>
jon-stumpf
force-pushed
the
k3s-uninstall
branch
from
37afc56
to
b3e2df8
Compare
|
I made additional commits to address gaps found in the implementation of k3s_server_location. In roles/reset/tasks/main.yml, the following errors were found:
|
jon-stumpf
changed the title
jon-stumpf
changed the title
…ation only used in k3s/master role Signed-off-by: Jon S. Stumpf <[email protected]>
…location is changed from the default Signed-off-by: Jon S. Stumpf <[email protected]>
Signed-off-by: Jon S. Stumpf <[email protected]>
Signed-off-by: Jon S. Stumpf <[email protected]>
Signed-off-by: Jon S. Stumpf <[email protected]>
This was referenced Dec 30, 2021
Closed
|
Closing as reset playbook now simply calls the K3s-uninstall.sh script #230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current reset role does not remove all network artifacts (#159). I updated the reset role to perform the same actions in the same order as k3s-uninstall.sh as provided by https://get.k3s.io. I used v1.22.4+k3s1 as the reference.