Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SELinux #199

Closed
wants to merge 4 commits into from
Closed

Add support for SELinux #199

wants to merge 4 commits into from

Conversation

tylergmuir
Copy link

Adds support for SELinux on CentOS 7 and 8 as well as RedHat Enterprise Linux 7 and 8.

@tylergmuir
Copy link
Author

#199

@dereknola
Copy link
Member

SELinux support is now automatically handled by using the K3s install script, added in #228

@dereknola dereknola closed this Nov 9, 2023
@tylergmuir
Copy link
Author

@dereknola The install script does handle the installation of the selinux rpm now, but in the prereqs task in this repo, the first step is to disable SELinux. In addition to that, it would probably be good to document that --selinux would need to be added to the extra_server_args and extra_agent_args for it to work appropriately.

Also, if you look at the changed files for this PR, it also fixes some issues that someone running a RHEL distro would run into, such as firewalld being enabled (which conflicts with k3s) and that the distro name in the when statements is incorrect for modern versions of ansible.

I would be happy to update my fork or open an updated PR if you would like, but I feel there are still issues here that should be addressed.

@dereknola
Copy link
Member

Hey @tylergmuir Those issues you mentioned are valid. I have an open issue for #234. I will open another issue to track SELinux working properly and make sure that it works correctly. As for the RHEL distro when statements, 45289ba merged today and should handle them correctly now.

Lookout for stuff tomorrow and next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants