do not blindly overwrite kube config #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roivanov
commented
Nov 30, 2023
roivanov
force-pushed
the
romani/save_config
branch
from
07d8ef3
to
c343d46
Compare
roivanov
commented
Nov 30, 2023
dereknola
requested changes
Nov 30, 2023
Signed-off-by: Roman Ivanov <[email protected]>
Signed-off-by: Roman Ivanov <[email protected]>
Signed-off-by: Roman Ivanov <[email protected]>
Signed-off-by: Roman Ivanov <[email protected]>
Signed-off-by: Roman Ivanov <[email protected]>
Signed-off-by: Roman Ivanov <[email protected]>
Signed-off-by: Roman Ivanov <[email protected]>
Co-authored-by: Derek Nola <[email protected]> Signed-off-by: Roman Ivanov <[email protected]>
Signed-off-by: Roman Ivanov <[email protected]>
roivanov
force-pushed
the
romani/save_config
branch
from
ff4e7b8
to
e709d7d
Compare
|
Guys, why not allow user to define kubeconfig location? We use multiple configs and export KUBECONFIG based on project - it's very convenient |
|
@zen I'm happy to open another future PR to address that case. I did think it was weird that this project originally overrode the base kubeconfig, but I kept it in because I didn't know if users actually liked that or what. |
dereknola
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Merge with existing kube config, do not overwrite existing file
Linked Issues
#259
One issue still needs to be addressed is when cluster names are identical