Make agent and server groups configurable #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meagan Harris <[email protected]>
dereknola
requested changes
Jun 4, 2024
|
Lint is failing for unrelated reason, I'll handle in another PR |
Co-authored-by: Derek Nola <[email protected]> Signed-off-by: Meagan Harris <[email protected]>
dereknola
approved these changes
Jun 4, 2024
steevi
pushed a commit
to steevi/k3s-ansible
that referenced
this pull request
Jul 2, 2024
* Make agent and server groups configurable Signed-off-by: Meagan Harris <[email protected]> * Fix typo in upgrade role Co-authored-by: Derek Nola <[email protected]> Signed-off-by: Meagan Harris <[email protected]> --------- Signed-off-by: Meagan Harris <[email protected]> Signed-off-by: Meagan Harris <[email protected]> Co-authored-by: Derek Nola <[email protected]>
andygodish
pushed a commit
to andygodish/k3s-ansible
that referenced
this pull request
Aug 9, 2024
* Make agent and server groups configurable Signed-off-by: Meagan Harris <[email protected]> * Fix typo in upgrade role Co-authored-by: Derek Nola <[email protected]> Signed-off-by: Meagan Harris <[email protected]> --------- Signed-off-by: Meagan Harris <[email protected]> Signed-off-by: Meagan Harris <[email protected]> Co-authored-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Inventory group names
serverandagentare configured throughserver_groupandagent_groupvariables.The use of hard-coded group names causes issues when managing multiple clusters within the same inventory. When the control plane is initialized each server node connects to the first member of the server group, and therefore all members of each
servergroup must belong to the same cluster.This change allows more flexibility in how operators manage their inventory. A configurable
agentgroup is added for completeness.Linked Issues
#327