Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move k3s.cattle.io CR types to github.com/k3s-io/api #11824

Open
brandond opened this issue Feb 20, 2025 · 2 comments
Open

Move k3s.cattle.io CR types to github.com/k3s-io/api #11824

brandond opened this issue Feb 20, 2025 · 2 comments
Assignees

Comments

@brandond
Copy link
Member

brandond commented Feb 20, 2025

As part of rancher/rancher#44452 Rancher needs to import the ETCDSnapshotFile custom resource types in order to sync the custom resources, instead of syncing from the snapshot metadata configmap. They are currently unable to do this without pulling in other unwanted bits of K3s.

This was touched on as a possible necessity in the etcd snapshot metadata ADR:
https://github.com/k3s-io/k3s/blob/master/docs/adrs/etcd-snapshot-cr.md#existing-work

We should move the CR types out to a separate repo - I am proposing github.com/k3s-io/api to mirror how the Kubernetes project publishes their types at github.com/kubernetes/api. Note that we need to move all types in the apigroup together, so the Addon stub CR type will move as well.

@brandond
Copy link
Member Author

brandond commented Feb 21, 2025

Initial copy of APIs at https://github.com/k3s-io/api/tree/main, with a dependency on github.com/rancher/wrangler/v3. If we need to fork additional branches for older wrangler major versions we can do so.

Long term we should probably drop wrangler in favor of native controller-gen.

@brandond
Copy link
Member Author

cc @jakefhyde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

1 participant