Move k3s.cattle.io APIs to github.com/k3s-io/api
#11827
Open
+19
−1,836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <[email protected]>
brandond
changed the title
k3s.cattle.io APIs to k3s-io/apik3s.cattle.io APIs to github.com/k3s-io/api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11827 +/- ##
==========================================
- Coverage 46.55% 45.10% -1.46%
==========================================
Files 208 190 -18
Lines 19548 19022 -526
==========================================
- Hits 9101 8579 -522
- Misses 9146 9206 +60
+ Partials 1301 1237 -64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Feb 21, 2025
jakefhyde
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Move
k3s.cattle.ioAPIs togithub.com/k3s-io/apiConsume these APIs from the external package, instead of maintaining a duplicate set here. Bonus side-effect of removing all use of k8s/wrangler codegen from this project; all we have left is go-bindata.
Types of Changes
codegen
Verification
Normal CI
Testing
Normal CI
Linked Issues
k3s.cattle.ioCR types togithub.com/k3s-io/api#11824User-Facing Change
Further Comments