NetSyncEnabled fixes (space-wizards#4811)

* NetSyncEnabled fixes * A
k3yw · Jan 5, 2024 · f2e9ed0 · f2e9ed0
1 parent 9e6d0aa
commit f2e9ed0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/Robust.Client/Player/PlayerManager.cs b/Robust.Client/Player/PlayerManager.cs
@@ -162,11 +162,14 @@ public override bool SetAttachedEntity(ICommonSession? session, EntityUid? uid,
                 return true;
             }
 
-            if (!EntManager.EnsureComponent(uid.Value, out EyeComponent eye))
+            if (!EntManager.HasComponent<EyeComponent>(uid.Value))
             {
                 if (_client.RunLevel != ClientRunLevel.SinglePlayerGame)
                     Sawmill.Warning($"Attaching local player to an entity {EntManager.ToPrettyString(uid)} without an eye. This eye will not be netsynced and may cause issues.");
+                var eye = (EyeComponent) Factory.GetComponent(typeof(EyeComponent));
+                eye.Owner = uid.Value;
                 eye.NetSyncEnabled = false;
+                EntManager.AddComponent(uid.Value, eye);
             }
 
             Sawmill.Info($"Attaching local player to {EntManager.ToPrettyString(uid)}.");

diff --git a/Robust.Shared/GameObjects/EntityManager.Components.cs b/Robust.Shared/GameObjects/EntityManager.Components.cs
@@ -318,10 +318,8 @@ private void AddComponentInternal<T>(EntityUid uid, T component, ComponentRegist
                 metadata ??= MetaQuery.GetComponentInternal(uid);
                 metadata.NetComponents.Add(netId, component);
             }
-            else
-            {
-                component.Networked = false;
-            }
+
+            component.Networked = reg.NetID != null;
 
             var eventArgs = new AddedComponentEventArgs(new ComponentEventArgs(component, uid), reg);
             ComponentAdded?.Invoke(eventArgs);

diff --git a/Robust.Shared/Player/SharedPlayerManager.cs b/Robust.Shared/Player/SharedPlayerManager.cs
@@ -12,6 +12,7 @@ namespace Robust.Shared.Player;
 internal abstract partial class SharedPlayerManager : ISharedPlayerManager
 {
     [Dependency] protected readonly IEntityManager EntManager = default!;
+    [Dependency] protected readonly IComponentFactory Factory = default!;
     [Dependency] protected readonly ILogManager LogMan = default!;
     [Dependency] protected readonly IGameTiming Timing = default!;
     [Dependency] private readonly INetManager _netMan = default!;