Create referenced ingress if GSLB is configured with Ingress annotations #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaguas
requested review from
donovanmuller,
k0da,
kuritka,
ytsarev and
jkremser
as code owners
abaguas
force-pushed
the
annotation/referenced
branch
5 times, most recently
from
494e215
to
998d571
Compare
Signed-off-by: Andre Baptista Aguas <[email protected]>
abaguas
force-pushed
the
annotation/referenced
branch
from
998d571
to
7c9b5df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles one of the prerequisites outlined in #1698 to decommission embedded ingresses.
By default a GSLB with a referenced Ingress will be created if a user adds
k8gbannotations to an Ingress resource.To smoothen the user migration:
annotationCreatesGSLBWithEmbeddedIngressIn v1.1 the option will be deleted and the code will be cleaned up to support only Referenced Ingresses.