fix: consider apiVersion when getting example yaml for crds #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves k8s-operatorhub#56. When getting example YAMLs for CRDs, apiVersion should be considered in cases where a CRD is shipped with >= 2 versions. Signed-off-by: Thuan Vo <[email protected]>
Signed-off-by: Thuan Vo <[email protected]>
Signed-off-by: Thuan Vo <[email protected]>
|
Hey @mvalarh, would I be able to get your or anyone's opinions on these changes? |
This was referenced Jul 15, 2024
|
Hi, would someone mind taking a look at this PR? This bug is still affecting the Cryostat Operator: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
Description
Motivations
See #56. Additionally, CRD that has no corresponding alm-example is showing an incorrect one if an example of the same kind (different version) is available. See cryostatio/cryostat-operator#909
How to test
Use the following CSV, which both specify a CRD with >= 2 versions.
Use the CSV with preview page to see the changes.