Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting new schema refactor #494

Merged
merged 2 commits into from
Aug 15, 2024
Merged

feat: supporting new schema refactor #494

merged 2 commits into from
Aug 15, 2024

Conversation

AlexsJones
Copy link
Member

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@AlexsJones AlexsJones requested review from a team as code owners August 8, 2024 14:01
@AlexsJones
Copy link
Member Author

k8sgpt-ai/k8sgpt#1219

@matthisholleville
Copy link
Contributor

You need to update your branch

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -212,3 +212,5 @@ status:
plural: ""
conditions: []
storedVersions: []


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 new lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is because I copied it over manually, ill remove

@AlexsJones AlexsJones merged commit 6c01390 into main Aug 15, 2024
7 checks passed
@AlexsJones AlexsJones deleted the feat/schema-refactor branch August 15, 2024 13:58
ronaldpetty pushed a commit to ronaldpetty/k8sgpt-operator that referenced this pull request Aug 18, 2024
Signed-off-by: AlexsJones <[email protected]>
Signed-off-by: Ronald Petty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants