feat: adds interplex as a caching provider #6048
AlexsJonesgolangci_lint.yaml
on: pull_request
golangci-lint
4m 17s
Annotations
8 errors
|
golangci-lint:
pkg/cache/interplex_based.go#L15
[golangci] reported by reviewdog 🐶
field `client` is unused (unused)
Raw Output:
pkg/cache/interplex_based.go:15:2: field `client` is unused (unused)
client InterplexClient
^
|
|
golangci-lint:
pkg/cache/interplex_based_test.go#L24
[golangci] reported by reviewdog 🐶
testinggoroutine: call to (*testing.T).Fatalf from a non-test goroutine (govet)
Raw Output:
pkg/cache/interplex_based_test.go:24:4: testinggoroutine: call to (*testing.T).Fatalf from a non-test goroutine (govet)
t.Fatalf("failed to listen: %v", err)
^
|
|
golangci-lint:
pkg/cache/interplex_based_test.go#L29
[golangci] reported by reviewdog 🐶
testinggoroutine: call to (*testing.T).Fatalf from a non-test goroutine (govet)
Raw Output:
pkg/cache/interplex_based_test.go:29:4: testinggoroutine: call to (*testing.T).Fatalf from a non-test goroutine (govet)
t.Fatalf("failed to serve: %v", err)
^
|
|
golangci-lint:
pkg/cache/interplex_based.go#L38
[golangci] reported by reviewdog 🐶
SA1019: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x. (staticcheck)
Raw Output:
pkg/cache/interplex_based.go:38:64: SA1019: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x. (staticcheck)
conn, err := grpc.NewClient(c.configuration.ConnectionString, grpc.WithInsecure(), grpc.WithBlock())
^
|
|
golangci-lint:
pkg/cache/interplex_based.go#L57
[golangci] reported by reviewdog 🐶
SA1019: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x. (staticcheck)
Raw Output:
pkg/cache/interplex_based.go:57:64: SA1019: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x. (staticcheck)
conn, err := grpc.NewClient(c.configuration.ConnectionString, grpc.WithInsecure(), grpc.WithBlock())
^
|
|
golangci-lint:
pkg/cache/interplex_based_test.go#L21
[golangci] reported by reviewdog 🐶
SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (staticcheck)
Raw Output:
pkg/cache/interplex_based_test.go:21:2: SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (staticcheck)
go func() {
^
|
|
golangci-lint:
pkg/cache/interplex_based.go#L39
[golangci] reported by reviewdog 🐶
SA5001: should check error returned from grpc.NewClient() before deferring conn.Close() (staticcheck)
Raw Output:
pkg/cache/interplex_based.go:39:2: SA5001: should check error returned from grpc.NewClient() before deferring conn.Close() (staticcheck)
defer conn.Close()
^
|
|
golangci-lint:
pkg/cache/interplex_based.go#L58
[golangci] reported by reviewdog 🐶
SA5001: should check error returned from grpc.NewClient() before deferring conn.Close() (staticcheck)
Raw Output:
pkg/cache/interplex_based.go:58:2: SA5001: should check error returned from grpc.NewClient() before deferring conn.Close() (staticcheck)
defer conn.Close()
^
|