test: added tests for the log analyzer #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaibhavMalik4187
force-pushed
the
log-analyzer-tests
branch
from
94254ed
to
c1bfbab
Compare
JuHyung-Son
reviewed
Mar 14, 2024
VaibhavMalik4187
force-pushed
the
log-analyzer-tests
branch
from
c1bfbab
to
8914eb0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
+ Coverage 69.12% 69.63% +0.51%
==========================================
Files 30 30
Lines 2552 2549 -3
==========================================
+ Hits 1764 1775 +11
+ Misses 746 727 -19
- Partials 42 47 +5 ☔ View full report in Codecov by Sentry. |
VaibhavMalik4187
force-pushed
the
log-analyzer-tests
branch
from
67c2ca7
to
f21c669
Compare
VaibhavMalik4187
force-pushed
the
log-analyzer-tests
branch
from
45dc027
to
f64a7fa
Compare
VaibhavMalik4187
force-pushed
the
log-analyzer-tests
branch
from
dfa0443
to
025b40b
Compare
AlexsJones
approved these changes
May 8, 2024
* Added new tests for `LogAnalyzer` defined in the `pkg/analyzer` package. Increased the code coverage of the `log.go` file to >90% Partially addresses: k8sgpt-ai#889 Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
log-analyzer-tests
branch
from
025b40b
to
b2da8f6
Compare
Thanks, I've rebased this branch to include the latest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Added new tests for
LogAnalyzerdefined in thepkg/analyzerpackage. Increased the code coverage of thelog.gofile to >90%Added
fake logsstring to theerrorPatternto enable the discovery of error logs during the tests.TODO: Find a method to edit logs of the containers defined in the Kubernetes client config.
Partially addresses: #889
✅ Checks