Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getting the error from status field for HPA analyzer #1164

Merged
merged 14 commits into from
Jul 22, 2024
Merged

feat: getting the error from status field for HPA analyzer #1164

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
96eef73
getting the error from status field for hpa analyzer
naveenthangaraj03 Jun 20, 2024
af1858e
Signed-off
naveenthangaraj03 Jun 26, 2024
2c11ad8
Merge branch 'main' into HPA-analyzer
AlexsJones Jul 8, 2024
55e622b
Updated the hpaAnalyzer_test.go
naveenthangaraj03 Jul 19, 2024
0a1cdb2
Merge branch 'HPA-analyzer' of https://github.com/naveenthangaraj03/k…
naveenthangaraj03 Jul 19, 2024
01c2c8f
Updated hpa_test.go
naveenthangaraj03 Jul 19, 2024
0414ceb
Updated the hpa
naveenthangaraj03 Jul 19, 2024
5d42f33
resolved conflicts
naveenthangaraj03 Jul 19, 2024
4e34302
Updated the Conflicts
naveenthangaraj03 Jul 19, 2024
b2d91af
Resolved all the conflicts
naveenthangaraj03 Jul 19, 2024
c99aec8
Merge branch 'main' into HPA-analyzer
matthisholleville Jul 20, 2024
91163d6
Updated the test case
naveenthangaraj03 Jul 20, 2024
da3c179
Merge branch 'HPA-analyzer' of https://github.com/naveenthangaraj03/k…
naveenthangaraj03 Jul 20, 2024
f949352
Merge branch 'main' into HPA-analyzer
matthisholleville Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pkg/analyzer/hpa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (HpaAnalyzer) Analyze(a common.Analyzer) ([]common.Result, error) {
"analyzer_name": kind,
})

list, err := a.Client.GetClient().AutoscalingV1().HorizontalPodAutoscalers(a.Namespace).List(a.Context, metav1.ListOptions{})
list, err := a.Client.GetClient().AutoscalingV2().HorizontalPodAutoscalers(a.Namespace).List(a.Context, metav1.ListOptions{})
if err != nil {
return nil, err
}
Expand All @@ -53,6 +53,18 @@ func (HpaAnalyzer) Analyze(a common.Analyzer) ([]common.Result, error) {
for _, hpa := range list.Items {
var failures []common.Failure


//check the error from status field
conditions := hpa.Status.Conditions
for _, condition := range conditions {
if condition.Status != "True" {
failures = append(failures, common.Failure{
Text: condition.Message,
Sensitive: []common.Sensitive{},
})
}
}

// check ScaleTargetRef exist
scaleTargetRef := hpa.Spec.ScaleTargetRef
var podInfo PodInfo
Expand Down
4 changes: 2 additions & 2 deletions pkg/common/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
keda "github.com/kedacore/keda/v2/apis/keda/v1alpha1"
regv1 "k8s.io/api/admissionregistration/v1"
appsv1 "k8s.io/api/apps/v1"
autov1 "k8s.io/api/autoscaling/v1"
autov2 "k8s.io/api/autoscaling/v2"
v1 "k8s.io/api/core/v1"
networkv1 "k8s.io/api/networking/v1"
policyv1 "k8s.io/api/policy/v1"
Expand Down Expand Up @@ -52,7 +52,7 @@ type PreAnalysis struct {
PersistentVolumeClaim v1.PersistentVolumeClaim
Endpoint v1.Endpoints
Ingress networkv1.Ingress
HorizontalPodAutoscalers autov1.HorizontalPodAutoscaler
HorizontalPodAutoscalers autov2.HorizontalPodAutoscaler
PodDisruptionBudget policyv1.PodDisruptionBudget
StatefulSet appsv1.StatefulSet
NetworkPolicy networkv1.NetworkPolicy
Expand Down
Loading