-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add label selector #1201
Merged
Merged
feat: add label selector #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuHyung-Son
force-pushed
the
issue-993
branch
2 times, most recently
from
July 17, 2024 15:47
50eab26
to
af6842c
Compare
arbreezy
reviewed
Jul 17, 2024
Signed-off-by: Alex Jones <[email protected]> Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: JuHyung-Son <[email protected]>
… v1.4.0-20240715142657-3785f0a44aae.2 (#1196) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung Son <[email protected]>
arbreezy
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR
AlexsJones
approved these changes
Jul 18, 2024
AlexsJones
added a commit
that referenced
this pull request
Oct 24, 2024
* feat: fix the custom-analysis printing (#1195) Signed-off-by: Alex Jones <[email protected]> Signed-off-by: JuHyung-Son <[email protected]> * feat: add label selector Signed-off-by: JuHyung-Son <[email protected]> * feat: add label selector on analyzers Signed-off-by: JuHyung-Son <[email protected]> * chore(deps): pin goreleaser/goreleaser-action action to 286f3b1 (#1171) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: JuHyung-Son <[email protected]> * fix(deps): update module buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc/go to v1.4.0-20240715142657-3785f0a44aae.2 (#1196) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: JuHyung-Son <[email protected]> * chore(deps): update actions/upload-artifact digest to 0b2256b (#1175) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: JuHyung-Son <[email protected]> * chore: update proto pkg version Signed-off-by: JuHyung-Son <[email protected]> * chore: fix typo Signed-off-by: JuHyung-Son <[email protected]> * feat: add label string to LabelSelector util func Signed-off-by: JuHyung-Son <[email protected]> * feat: add test using 2 label selector Signed-off-by: JuHyung-Son <[email protected]> --------- Signed-off-by: Alex Jones <[email protected]> Signed-off-by: JuHyung-Son <[email protected]> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: JuHyung Son <[email protected]> Co-authored-by: Alex Jones <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: AlexsJones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add label selector on cmd, analysis, server . so users can use
analyze
with label selectorsCloses #993
📑 Description
grpc scheme should be merged and need to update scheme package.
k8sgpt-ai/schemas#28
✅ Checks
ℹ Additional Information