Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add label selector #1201

Merged
merged 11 commits into from
Jul 18, 2024
Merged

feat: add label selector #1201

merged 11 commits into from
Jul 18, 2024

Conversation

JuHyung-Son
Copy link
Contributor

@JuHyung-Son JuHyung-Son commented Jul 16, 2024

Add label selector on cmd, analysis, server . so users can use analyze with label selectors

Closes #993

📑 Description

grpc scheme should be merged and need to update scheme package.
k8sgpt-ai/schemas#28

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@JuHyung-Son JuHyung-Son requested review from a team as code owners July 16, 2024 14:40
@JuHyung-Son JuHyung-Son force-pushed the issue-993 branch 2 times, most recently from 50eab26 to af6842c Compare July 17, 2024 15:47
cmd/analyze/analyze.go Outdated Show resolved Hide resolved
pkg/analyzer/gateway.go Outdated Show resolved Hide resolved
AlexsJones and others added 10 commits July 18, 2024 22:13
Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: JuHyung-Son <[email protected]>
… v1.4.0-20240715142657-3785f0a44aae.2 (#1196)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR

@arbreezy arbreezy changed the title feat: add label selctor feat: add label selector Jul 18, 2024
cmd/analyze/analyze.go Outdated Show resolved Hide resolved
cmd/analyze/analyze.go Outdated Show resolved Hide resolved
@AlexsJones AlexsJones enabled auto-merge (squash) July 18, 2024 13:31
@AlexsJones AlexsJones merged commit eb3b81f into main Jul 18, 2024
11 checks passed
@AlexsJones AlexsJones deleted the issue-993 branch July 18, 2024 13:31
AlexsJones added a commit that referenced this pull request Oct 24, 2024
* feat: fix the custom-analysis printing (#1195)

Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>

* feat: add label selector

Signed-off-by: JuHyung-Son <[email protected]>

* feat: add label selector on analyzers

Signed-off-by: JuHyung-Son <[email protected]>

* chore(deps): pin goreleaser/goreleaser-action action to 286f3b1 (#1171)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: JuHyung-Son <[email protected]>

* fix(deps): update module buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc/go to v1.4.0-20240715142657-3785f0a44aae.2 (#1196)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: JuHyung-Son <[email protected]>

* chore(deps): update actions/upload-artifact digest to 0b2256b (#1175)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: JuHyung-Son <[email protected]>

* chore: update proto pkg version

Signed-off-by: JuHyung-Son <[email protected]>

* chore: fix typo

Signed-off-by: JuHyung-Son <[email protected]>

* feat: add label string to LabelSelector util func

Signed-off-by: JuHyung-Son <[email protected]>

* feat: add test using 2 label selector

Signed-off-by: JuHyung-Son <[email protected]>

---------

Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: JuHyung-Son <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: JuHyung Son <[email protected]>
Co-authored-by: Alex Jones <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: AlexsJones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add label selector on analyzer cmd
3 participants