Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom analysis paralelism #1203

Merged
merged 4 commits into from
Jul 20, 2024
Merged

feat: custom analysis paralelism #1203

merged 4 commits into from
Jul 20, 2024

Conversation

matthisholleville
Copy link
Contributor

Closes #

📑 Description

  • add parallelism when custom analysis is run
  • remove redundant parallelism declaration when classic analysis is run

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@matthisholleville matthisholleville requested review from a team as code owners July 18, 2024 16:17
AlexsJones
AlexsJones approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I will need to test it manually as we can't unit test this very effectively right now

@AlexsJones
Copy link
Member

Tested LGTM

@matthisholleville matthisholleville merged commit f1b7b37 into k8sgpt-ai:main Jul 20, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 20, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Aug 4, 2024
Merged
AlexsJones pushed a commit that referenced this pull request Oct 24, 2024
@matthisholleville @AlexsJones
feat: custom analysis paralelism (#1203)
cc9c05d 
Signed-off-by: AlexsJones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthisholleville @AlexsJones