feat: add custom-analyzer cmd #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the ability to manage custom analyzers in the K8sGPT application, enabling users to add, deploy, and configure custom analyzers from various sources. This enhancement supports extending the application's analytical capabilities by integrating external analysis tools, thus offering more flexibility and customization options to meet specific user needs. Signed-off-by: Matthis Holleville <[email protected]>
Introduced the ability to remove custom analyzers, streamlining the management process and ensuring flexibility in custom analyzer configuration. This enhancement addresses the need for dynamic customization and maintenance of analyzer setups, facilitating easier updates and modifications to the analysis environment. Signed-off-by: Matthis Holleville <[email protected]>
…alyzers Implemented a new list command within the customAnalyzer module to enable users to view all configured custom analyzers. This enhancement aims to improve usability by providing a straightforward method for users to inspect their custom analyzer configurations directly from the command line. Signed-off-by: Matthis Holleville <[email protected]>
This update introduces commands to manage custom analyzers in the k8sgpt tool, enhancing flexibility and control over analyzer configurations without the need for direct installation or docker dependency. Signed-off-by: Matthis Holleville <[email protected]>
|
Just curious, does it support the analyzers with custom CRDs? |
|
@DonCorleone92 you can develop your own analyzer logic, so yes, you can analyze any type of CRDs. You just need to integrate them into your analyzer logic. As for the AI provider, you can use the widely available ones ( like openai, ... ), but I recommend training a model with LocalAI using your custom CRDs. The AI's analysis recommendations will be more accurate this way. |
|
Great PR @matthisholleville, i think we should support private registries as well |
|
@arbreezy Shouldn't we refer to daemon authentication ( docker login ) instead? |
Oh if it picks it up automatically, then it should be fine |
|
Well spotted, @arbreezy ! Thanks to your comment, I noticed another issue. The version you reviewed never performed a |
Added authentication support for pulling private Docker images when adding custom analyzers, enhancing security and access control. Signed-off-by: Matthis Holleville <[email protected]>
matthisholleville
force-pushed
the
custom-analyzers-cmd
branch
from
1ee5add to
6c62558
Compare
|
We probably need an example of at least one custom analyzer wrapped in a docker container before we merge this |
|
@matthisholleville I love the PR and the enthusiasm. I'd like you to break it up into two pieces please. In the second PR we can discuss the "--pull" flag mechanics (what you've done in docker). e.g. |
|
@AlexsJones I removed Docker installation type |
Removed the installation and deployment functionality for custom analyzers, streamlining the process of adding analyzers. This change focuses on simplifying the configuration by eliminating the need for specifying installation types, package URLs, and authentication details for Docker images. The goal is to enhance user experience by making the addition of custom analyzers more straightforward and less error-prone. Signed-off-by: Matthis Holleville <[email protected]>
matthisholleville
force-pushed
the
custom-analyzers-cmd
branch
from
a7b1482 to
59f98bb
Compare
Signed-off-by: Matthis Holleville <[email protected]>
AlexsJones
reviewed
Aug 5, 2024
AlexsJones
requested changes
Aug 5, 2024
Signed-off-by: Matthis Holleville <[email protected]>
To ensure the integrity and consistency of analyzer names, we introduced a validation step that checks the format of the name against a predefined regex pattern. This change aims to prevent the creation of analyzers with invalid names, enhancing the system's reliability and usability. Signed-off-by: Matthis Holleville <[email protected]>
Refactored the customAnalyzer package and its references to use consistent snake_case naming for improved code readability and alignment with Go naming conventions. Signed-off-by: Matthis Holleville <[email protected]>
AlexsJones
approved these changes
Aug 10, 2024
ronaldpetty
pushed a commit
to ronaldpetty/k8sgpt
that referenced
this pull request
Aug 17, 2024
* feat: add custom analyzer management capability Introduced the ability to manage custom analyzers in the K8sGPT application, enabling users to add, deploy, and configure custom analyzers from various sources. This enhancement supports extending the application's analytical capabilities by integrating external analysis tools, thus offering more flexibility and customization options to meet specific user needs. Signed-off-by: Matthis Holleville <[email protected]> * feat: enhance custom analyzer management with removal functionality Introduced the ability to remove custom analyzers, streamlining the management process and ensuring flexibility in custom analyzer configuration. This enhancement addresses the need for dynamic customization and maintenance of analyzer setups, facilitating easier updates and modifications to the analysis environment. Signed-off-by: Matthis Holleville <[email protected]> * feat: add list command to customAnalyzer for displaying configured analyzers Implemented a new list command within the customAnalyzer module to enable users to view all configured custom analyzers. This enhancement aims to improve usability by providing a straightforward method for users to inspect their custom analyzer configurations directly from the command line. Signed-off-by: Matthis Holleville <[email protected]> * feat: add support for listing, adding, and removing custom analyzers This update introduces commands to manage custom analyzers in the k8sgpt tool, enhancing flexibility and control over analyzer configurations without the need for direct installation or docker dependency. Signed-off-by: Matthis Holleville <[email protected]> * feat: support private docker image authentication for custom analyzers Added authentication support for pulling private Docker images when adding custom analyzers, enhancing security and access control. Signed-off-by: Matthis Holleville <[email protected]> * feat: remove Docker custom analyzer installation Removed the installation and deployment functionality for custom analyzers, streamlining the process of adding analyzers. This change focuses on simplifying the configuration by eliminating the need for specifying installation types, package URLs, and authentication details for Docker images. The goal is to enhance user experience by making the addition of custom analyzers more straightforward and less error-prone. Signed-off-by: Matthis Holleville <[email protected]> * fix: remove unused packageUrl Signed-off-by: Matthis Holleville <[email protected]> * feat: update add command description to reflect broader functionality Signed-off-by: Matthis Holleville <[email protected]> * feat: Add name validation for custom analyzer creation To ensure the integrity and consistency of analyzer names, we introduced a validation step that checks the format of the name against a predefined regex pattern. This change aims to prevent the creation of analyzers with invalid names, enhancing the system's reliability and usability. Signed-off-by: Matthis Holleville <[email protected]> * feat: refactor customAnalyzer package for consistent naming Refactored the customAnalyzer package and its references to use consistent snake_case naming for improved code readability and alignment with Go naming conventions. Signed-off-by: Matthis Holleville <[email protected]> --------- Signed-off-by: Matthis Holleville <[email protected]> Signed-off-by: Ronald Petty <[email protected]>
AlexsJones
pushed a commit
that referenced
this pull request
Oct 24, 2024
* feat: add custom analyzer management capability Introduced the ability to manage custom analyzers in the K8sGPT application, enabling users to add, deploy, and configure custom analyzers from various sources. This enhancement supports extending the application's analytical capabilities by integrating external analysis tools, thus offering more flexibility and customization options to meet specific user needs. Signed-off-by: Matthis Holleville <[email protected]> * feat: enhance custom analyzer management with removal functionality Introduced the ability to remove custom analyzers, streamlining the management process and ensuring flexibility in custom analyzer configuration. This enhancement addresses the need for dynamic customization and maintenance of analyzer setups, facilitating easier updates and modifications to the analysis environment. Signed-off-by: Matthis Holleville <[email protected]> * feat: add list command to customAnalyzer for displaying configured analyzers Implemented a new list command within the customAnalyzer module to enable users to view all configured custom analyzers. This enhancement aims to improve usability by providing a straightforward method for users to inspect their custom analyzer configurations directly from the command line. Signed-off-by: Matthis Holleville <[email protected]> * feat: add support for listing, adding, and removing custom analyzers This update introduces commands to manage custom analyzers in the k8sgpt tool, enhancing flexibility and control over analyzer configurations without the need for direct installation or docker dependency. Signed-off-by: Matthis Holleville <[email protected]> * feat: support private docker image authentication for custom analyzers Added authentication support for pulling private Docker images when adding custom analyzers, enhancing security and access control. Signed-off-by: Matthis Holleville <[email protected]> * feat: remove Docker custom analyzer installation Removed the installation and deployment functionality for custom analyzers, streamlining the process of adding analyzers. This change focuses on simplifying the configuration by eliminating the need for specifying installation types, package URLs, and authentication details for Docker images. The goal is to enhance user experience by making the addition of custom analyzers more straightforward and less error-prone. Signed-off-by: Matthis Holleville <[email protected]> * fix: remove unused packageUrl Signed-off-by: Matthis Holleville <[email protected]> * feat: update add command description to reflect broader functionality Signed-off-by: Matthis Holleville <[email protected]> * feat: Add name validation for custom analyzer creation To ensure the integrity and consistency of analyzer names, we introduced a validation step that checks the format of the name against a predefined regex pattern. This change aims to prevent the creation of analyzers with invalid names, enhancing the system's reliability and usability. Signed-off-by: Matthis Holleville <[email protected]> * feat: refactor customAnalyzer package for consistent naming Refactored the customAnalyzer package and its references to use consistent snake_case naming for improved code readability and alignment with Go naming conventions. Signed-off-by: Matthis Holleville <[email protected]> --------- Signed-off-by: Matthis Holleville <[email protected]> Signed-off-by: AlexsJones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
Introduced the ability to manage custom analyzers in the K8sGPT application, enabling users to a
dd, deploy, and configure custom analyzers from various sources. This enhancement supports extending
the application's analytical capabilities by integrating external analysis tools, thus offering mor
e flexibility and customization options to meet specific user needs.
✅ Checks
ℹ Additional Information
demo-custom-analyzers.mov