Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add claude backend #1297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tssurya
Copy link

@tssurya tssurya commented Nov 3, 2024

This is my first pull request to this repo, I need to add some docs and tests, would need some pointers on where exactly to change them.

📑 Description

This PR adds support for using claude backend with k8sgpt.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

@tssurya tssurya requested review from a team as code owners November 3, 2024 09:37
@tssurya tssurya changed the title Add claude backend feat: Add claude backend Nov 3, 2024
@tssurya tssurya changed the title feat: Add claude backend feat: add claude backend Nov 3, 2024
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an entry into pkg/ai/iai.go

e.g.,

	clients = []IAI{
		&OpenAIClient{},
		&AzureAIClient{},
		&LocalAIClient{},
		&OllamaClient{},
		&NoOpAIClient{},
		&CohereClient{},
		&AmazonBedRockClient{},
		&SageMakerAIClient{},
		&GoogleGenAIClient{},
		&HuggingfaceClient{},
		&GoogleVertexAIClient{},
		&OCIGenAIClient{},
		&IBMWatsonxAIClient{},
	}
	Backends = []string{
		openAIClientName,
		localAIClientName,
		ollamaClientName,
		azureAIClientName,
		cohereAIClientName,
		amazonbedrockAIClientName,
		amazonsagemakerAIClientName,
		googleAIClientName,
		noopAIClientName,
		huggingfaceAIClientName,
		googleVertexAIClientName,
		ociClientName,
		ibmWatsonxAIClientName,
	}

Also - is this a passwordless provider?

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 34.59%. Comparing base (173e4dc) to head (fcc1802).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ai/anthropic.go 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
- Coverage   34.76%   34.59%   -0.17%     
==========================================
  Files          94       95       +1     
  Lines        6342     6373      +31     
==========================================
  Hits         2205     2205              
- Misses       4046     4077      +31     
  Partials       91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposed
Development

Successfully merging this pull request may close these issues.

2 participants