Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gopath to gitignore #293

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add gopath to gitignore #293

merged 1 commit into from
Nov 23, 2023

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Nov 16, 2023 •
edited
Loading

What this PR does / why we need it:
Add gopath to gitignore (created when using make dep)

Special notes for your reviewer:
once merged we might want to cherry-pick also to
release-0.31 | release-0.29 | release-0.26

Release note:

None

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 16, 2023
@oshoval
Copy link
Member Author

oshoval commented Nov 16, 2023

/retest

@phoracek
Copy link
Member

OVS CNI has a user base outside CNAO. It is not justified to change its development tooling to be in sync with another project.

If you drop the target change and keep the gitignore modification, I will be happy to merge this.

@oshoval
Copy link
Member Author

oshoval commented Nov 19, 2023 •
edited
Loading

Sure thx

is it fine btw to add another target and not replace ? (can be done also on follow PR if so)
or double target doesnt make sense

@oshoval oshoval changed the title makefile: Rename dep target to vendor Add gopath to gitignore Nov 19, 2023
@oshoval
Copy link
Member Author

oshoval commented Nov 19, 2023

Updated

@oshoval
add gopath to gitignore
b1f65d0 
Signed-off-by: Or Shoval <[email protected]>
phoracek
phoracek approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@phoracek
Copy link
Member

I would rather not add a target to make it slightly more convenient for other projects. Sorry for the complication.

@kubevirt-bot kubevirt-bot merged commit 70e52f7 into k8snetworkplumbingwg:main Nov 23, 2023
4 checks passed
@oshoval
Copy link
Member Author

oshoval commented Nov 28, 2023

Np
btw if you want to consider an alias instead of a new target, anyhow not biggie
vendor: dep

@oshoval
Copy link
Member Author

oshoval commented Nov 28, 2023

/cherry-pick release-0.31

@oshoval
Copy link
Member Author

oshoval commented Nov 28, 2023

/cherry-pick release-0.29

@oshoval
Copy link
Member Author

oshoval commented Nov 28, 2023

/cherry-pick release-0.26

@kubevirt-bot
Copy link
Collaborator

@oshoval: new pull request created: #299

In response to this:

/cherry-pick release-0.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 28, 2023
Merged
Merged
@kubevirt-bot
Copy link
Collaborator

@oshoval: new pull request created: #298

In response to this:

/cherry-pick release-0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Collaborator

@oshoval: new pull request created: #300

In response to this:

/cherry-pick release-0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshoval @phoracek @kubevirt-bot