-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alpine image in Dockerfile #414
Merged
zshi-redhat
merged 1 commit into
k8snetworkplumbingwg:master
from
adrianchiris:update-alpine-in-dockerfile
Apr 12, 2022
Merged
Update alpine image in Dockerfile #414
zshi-redhat
merged 1 commit into
k8snetworkplumbingwg:master
from
adrianchiris:update-alpine-in-dockerfile
Apr 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bn222
reviewed
Mar 22, 2022
This was referenced Mar 22, 2022
adrianchiris
force-pushed
the
update-alpine-in-dockerfile
branch
from
March 22, 2022 16:36
f610539
to
02316f8
Compare
\lgtm |
moshe010
approved these changes
Mar 23, 2022
alpine image has been pinned to 3.12 due to issues that have already been resolved. since sriov-network-device plugin image now properly builds with latest alpine images, we can set it in Dockerfile. git is now installed in the build container as it is no longer available in latest images. As an additional benefit this will fix container image related security vulnerabilities as new images are published. Signed-off-by: Adrian Chiris <[email protected]>
adrianchiris
force-pushed
the
update-alpine-in-dockerfile
branch
from
March 28, 2022 18:42
02316f8
to
ccd8664
Compare
Thanks for addressing the Github action. \lgtm |
e0ne
reviewed
Apr 8, 2022
e0ne
reviewed
Apr 8, 2022
@SchSeba @zshi-redhat can we merge this ? |
@adrianchiris I think we can mark all the reviews/comments as resolved. I think it is something only you can do? |
zshi-redhat
approved these changes
Apr 12, 2022
image push to ppc64le and arm64 failed: On arm64
On ppc64le
|
I think this might have to do with caches? We explicitly add git to avoid this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alpine image has been pinned to 3.12 due to issues
that have already been resolved.
since sriov-network-device plugin image now properly builds
with latest alpine images, we can set it in Dockerfile.
As an additional benefit this will fix container image
related security vulnerabilities as new images are published.
Signed-off-by: Adrian Chiris [email protected]