Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpine image in Dockerfile #414

Conversation

adrianchiris
Copy link
Contributor

alpine image has been pinned to 3.12 due to issues
that have already been resolved.

since sriov-network-device plugin image now properly builds
with latest alpine images, we can set it in Dockerfile.

As an additional benefit this will fix container image
related security vulnerabilities as new images are published.

Signed-off-by: Adrian Chiris [email protected]

@adrianchiris
Copy link
Contributor Author

#407

@bn222
Copy link
Contributor

bn222 commented Mar 22, 2022

\lgtm

alpine image has been pinned to 3.12 due to issues
that have already been resolved.

since sriov-network-device plugin image now properly builds
with latest alpine images, we can set it in Dockerfile.

git is now installed in the build container as it is
no longer available in latest images.

As an additional benefit this will fix container image
related security vulnerabilities as new images are published.

Signed-off-by: Adrian Chiris <[email protected]>
@bn222
Copy link
Contributor

bn222 commented Apr 1, 2022

Thanks for addressing the Github action.

\lgtm

images/Dockerfile Show resolved Hide resolved
images/Dockerfile Show resolved Hide resolved
@adrianchiris
Copy link
Contributor Author

@SchSeba @zshi-redhat can we merge this ?

@bn222
Copy link
Contributor

bn222 commented Apr 12, 2022

@adrianchiris I think we can mark all the reviews/comments as resolved. I think it is something only you can do?

@zshi-redhat zshi-redhat merged commit 58eb366 into k8snetworkplumbingwg:master Apr 12, 2022
@zshi-redhat
Copy link
Collaborator

image push to ppc64le and arm64 failed:

On arm64

#12 38.13 go: downloading golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1
#12 39.97 go: missing Git command. See https://golang.org/s/gogetcmd
#12 39.98 error obtaining VCS status: exec: "git": executable file not found in $PATH
#12 39.98 	Use -buildvcs=false to disable VCS stamping.
#12 39.98 make: *** [Makefile:72: /usr/src/sriov-network-device-plugin/build/sriovdp] Error 1
#12 ERROR: process "/bin/sh -c apk add --update --virtual build-dependencies build-base linux-headers make &&     cd /usr/src/sriov-network-device-plugin &&     make clean &&     make build" did not complete successfully: exit code: 2

On ppc64le

#12 49.66 error obtaining VCS status: exec: "git": executable file not found in $PATH
#12 49.66 	Use -buildvcs=false to disable VCS stamping.
#12 49.66 make: *** [Makefile:72: /usr/src/sriov-network-device-plugin/build/sriovdp] Error 1
#12 ERROR: process "/bin/sh -c apk add --update --virtual build-dependencies build-base linux-headers make &&     cd /usr/src/sriov-network-device-plugin &&     make clean &&     make build" did not complete successfully: exit code: 2

@bn222
Copy link
Contributor

bn222 commented Apr 12, 2022

I think this might have to do with caches? We explicitly add git to avoid this error.

@adrianchiris adrianchiris deleted the update-alpine-in-dockerfile branch July 12, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants