Allow to filter net devices by Infiniband Partition Key #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7914659039Details
💛 - Coveralls |
Eoghan1232
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
@almaslennikov Thanks for the contribution!
this looks good to me, could you fix the lint issue as well? just remove the commented out line.
Eoghan1232
reviewed
Jan 10, 2024
almaslennikov
force-pushed
the
pkey-selector
branch
2 times, most recently
from
bbaac0f to
073df9b
Compare
|
The new sriovnet dependency requires upgrading to go1.21. I've created a separate PR to update the toolchain: #527 |
|
@almaslennikov can you sort out lint issue? |
almaslennikov
force-pushed
the
pkey-selector
branch
2 times, most recently
from
15ce663 to
a8f45fb
Compare
|
@adrianchiris @Eoghan1232 the linter issues are fixed |
Eoghan1232
approved these changes
Feb 1, 2024
|
/retest |
|
/retest-kubernetes-ci |
adrianchiris
reviewed
Feb 6, 2024
almaslennikov
force-pushed
the
pkey-selector
branch
from
a8f45fb to
68e7c3f
Compare
This function wraps sriovnet.GetDefaultPKeyFromPci and returns the default IB Partition Key for an Infiniband device Signed-off-by: amaslennikov <[email protected]>
Add a new interface function + implement it in pciNetDevice struct Signed-off-by: amaslennikov <[email protected]>
Signed-off-by: amaslennikov <[email protected]>
Signed-off-by: amaslennikov <[email protected]>
Signed-off-by: amaslennikov <[email protected]>
almaslennikov
force-pushed
the
pkey-selector
branch
from
68e7c3f to
b6ce7be
Compare
|
@adrianchiris Thank you for the review! Addressed your comments |
Signed-off-by: amaslennikov <[email protected]>
almaslennikov
force-pushed
the
pkey-selector
branch
from
b6ce7be to
93507ca
Compare
adrianchiris
approved these changes
Feb 15, 2024
|
@Eoghan1232 could you take a quick look at the lastest iteration ? if all is ok id like to merge this one |
Eoghan1232
approved these changes
Feb 15, 2024
|
@adrianchiris are we waiting for all CI to pass or can we merge this? |
|
we can merge. we have issues with CI that need to be sorted internally. |
adrianchiris
merged commit 1a99d09
into
k8snetworkplumbingwg:master
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced a new kind of device selector based on Infiniband Partition Key.
The PKey retrieval functionality is taken from sriovnet. This PR will be finalized with updated sriovnet dependency when the (related PR there) is merged