-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config-daemon: Improve logging of draining state #494
config-daemon: Improve logging of draining state #494
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 5950522014
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, small nit
Executions of `nodeUpdateHandler` are not tracked by logs, that make debugging problems harder. Signed-off-by: Andrea Panattoni <[email protected]>
bbaa2d5
to
3e16640
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Executions of
nodeUpdateHandler
are not tracked by logs,that make debugging problems harder.
Also, adding a log line to write the node name the config-daemon is working on.
Note: part of this work will be superseded by
but it's still useful to deal with draining issue while waiting for that PR.