Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-daemon: Improve logging of draining state #494

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Aug 23, 2023

Executions of nodeUpdateHandler are not tracked by logs,
that make debugging problems harder.

Also, adding a log line to write the node name the config-daemon is working on.

Note: part of this work will be superseded by

but it's still useful to deal with draining issue while waiting for that PR.

@zeeke zeeke marked this pull request as ready for review August 23, 2023 11:09
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5950522014

  • 9 of 13 (69.23%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 24.769%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 9 13 69.23%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 64.15%
controllers/sriovnetwork_controller.go 2 67.62%
Totals Coverage Status
Change from base Build 5949253686: 0.09%
Covered Lines: 2122
Relevant Lines: 8567

💛 - Coveralls

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

pkg/daemon/daemon.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, small nit

Executions of `nodeUpdateHandler` are not tracked by logs,
that make debugging problems harder.

Signed-off-by: Andrea Panattoni <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris adrianchiris merged commit 14c6765 into k8snetworkplumbingwg:master Sep 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants