Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Increase verbosity of NeedToUpdateSriov #810

Merged

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Nov 26, 2024

Knowing the reason that triggered a node reconfiguration is an critical point while debugging production system.

Increase the verbosity of all the case where NeedToUpdateSriov returns true.

Knowing the reason that triggered a node reconfiguration is an critical point
while debugging production system.

Increase the verbosity of all the case where `NeedToUpdateSriov` returns true.

Signed-off-by: Andrea Panattoni <[email protected]>
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12034918837

Details

  • 7 of 11 (63.64%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 47.159%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/v1/helper.go 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
controllers/generic_network_controller.go 5 74.38%
Totals Coverage Status
Change from base Build 12031834206: -0.007%
Covered Lines: 7188
Relevant Lines: 15242

💛 - Coveralls

@zeeke zeeke merged commit 5f492e5 into k8snetworkplumbingwg:master Nov 27, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants