Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch gomock lib to supported one #842

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Feb 9, 2025

original gomock lib is not supported anymore
switching to the uber supported fork

original gomock lib is not supported anymore
switching to the uber supported fork

Signed-off-by: Sebastian Sch <[email protected]>
Copy link

github-actions bot commented Feb 9, 2025

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13228824770

Details

  • 90 of 201 (44.78%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 47.356%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/host/internal/lib/netlink/mock/mock_netlink.go 16 17 94.12%
pkg/host/store/mock/mock_store.go 3 4 75.0%
pkg/platforms/openstack/mock/mock_openstack.go 0 1 0.0%
pkg/plugins/mock/mock_plugin.go 1 2 50.0%
pkg/utils/mock/mock_utils.go 3 4 75.0%
pkg/platforms/mock/mock_platforms.go 2 5 40.0%
pkg/platforms/openshift/mock/mock_openshift.go 0 4 0.0%
pkg/vendors/mellanox/mock/mock_mellanox.go 0 5 0.0%
pkg/host/mock/mock_host.go 27 63 42.86%
pkg/helper/mock/mock_helper.go 18 76 23.68%
Totals Coverage Status
Change from base Build 13109399258: 0.07%
Covered Lines: 7264
Relevant Lines: 15339

💛 - Coveralls

@adrianchiris adrianchiris merged commit 8d35466 into k8snetworkplumbingwg:master Feb 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants