Extend current ImageConfig to allow more values to images as well as … #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR still missing modifications to ImagePullPolicy for certain imageTypes in the CassandraDatacenter spec.. |
burmanm
force-pushed
the
refactor_imageconfig
branch
from
3a90099
to
884800c
Compare
burmanm
force-pushed
the
refactor_imageconfig
branch
from
884800c
to
2b79709
Compare
…additional configuration options for each image type Add modified PullPolicy to containers Add ability to restrict pullSecrets added per pod Make internal imageConfig to be non-pointer to allow easier usage in tests Make some pointer accesses safer
burmanm
force-pushed
the
refactor_imageconfig
branch
from
a714810
to
fb9eb8c
Compare
adejanovski
reviewed
Oct 21, 2024
| @@ -35,11 +34,17 @@ type ImageConfig struct { | |||
|
|
|||
| DefaultImages *DefaultImages `json:"defaults,omitempty"` | |||
|
|
|||
| ImagePolicy | |||
There was a problem hiding this comment.
Question: is this missing json:",inline"?
There was a problem hiding this comment.
No, it doesn't make any difference in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Part of the implementation of k8ssandra/k8ssandra-operator#532
Which issue(s) this PR fixes:
Fixes k8ssandra/k8ssandra-operator#532
Fixes #636
Checklist