Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stuff from previous controller-runtime upgrade #630

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Apr 5, 2024

What this PR does:

  • Use TerminalError() when we did get an error, but do not want to reconcile.
  • Update OLM stuff
  • Change kind to use port 5001 instead of 5000 for local registry to help Mac users.
  • Remove use of deprecated "k8s.io/utils/pointer"
  • Also, add back some basic tests for reconcile

Which issue(s) this PR fixes:
Related #617

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

…ncile. Update OLM stuff, change kind to use port 5001 instead of 5000 for local registry to help Mac users. Also, add back some basic tests for reconcile
@burmanm burmanm requested a review from a team as a code owner April 5, 2024 16:41
Copy link

github-actions bot commented Apr 5, 2024

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@burmanm burmanm merged commit 357636e into k8ssandra:master Apr 18, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants