-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8OP-295 Expose Medusa's gRPC server port configuration #1456
Conversation
@adejanovski , I've used the Github UI to resolve the merge conflict (it was just a changelog entry). But it now made a merge commit. I'm not sure that's what we want. Please let me know if it's a no-no and I'll redo this, most likely with an entirely new branch into which I'll cherry-pick the relevant commits. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
==========================================
- Coverage 59.02% 58.99% -0.03%
==========================================
Files 125 125
Lines 12695 12763 +68
==========================================
+ Hits 7493 7530 +37
- Misses 4524 4553 +29
- Partials 678 680 +2
|
I had to rebase this to resolve another conflict. The merge commit went away, and the CI is green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one blocking comment on using a multi arch image by default, and one quick refactoring suggestion.
Co-authored-by: Alexander Dejanovski <[email protected]>
Quality Gate passedIssues Measures |
What this PR does:
This PR allows users of k8ssandra-operator to specify newly-added config field in Medusa that controls which port Medusa will use to start its gRPC server on.
Update: Manual testing discolosed some formatting issues (bad space type) in the to-be medusa config map. That's fixed now and the PR is ready to go.
Which issue(s) this PR fixes:
Fixes #1455
Checklist