Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using CMake #33

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Build using CMake #33

wants to merge 2 commits into from

Conversation

pinkavaj
Copy link
Contributor

@pinkavaj pinkavaj commented Nov 14, 2022

Replace plain make build by CMake. The goal is to:

  • Make the build system more platform independent
  • Check for presence of libraries and build only relevant modules

TODO:

  • Simplify the initial CMake file
  • Add necessary documentation to ensure easy build for every newcommer
  • Make the builds which depend on specific libraries optional (eg, rtlsdr, funcube ...)
  • Ensure all the features and optimisations from old Makefile are ported correctly.
  • Test on Linux
  • Test on MacOsX
  • Test on other system?

@ka9q
Copy link
Owner

ka9q commented Nov 15, 2022

Thank you! I've never written for cmake myself.

@pinkavaj pinkavaj force-pushed the pi-cmake branch 7 times, most recently from f4f14ea to d823a90 Compare November 20, 2022 22:08
@pinkavaj
Copy link
Contributor Author

@ka9q Ok, the initial version is ready, there is still some tweaks to do, but feedback is really welcome (from anybody of course).

@pinkavaj pinkavaj force-pushed the pi-cmake branch 21 times, most recently from d6e77c4 to 51efe1d Compare November 25, 2022 00:01
@pinkavaj pinkavaj force-pushed the pi-cmake branch 2 times, most recently from 6fc6994 to bab3ec7 Compare November 25, 2022 00:09
@ka9q
Copy link
Owner

ka9q commented Apr 3, 2024

Sorry for letting this sit for so long. I'm still unfamiliar with both cmake and with handling git pull requests. Do you still want me to merge this, or do you want to look at it again?

@ka9q
Copy link
Owner

ka9q commented Jan 14, 2025

I've cleaned up the existing makefiles quite a bit, so I'm not sure how important it still is to switch to cmake right now. Comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants