Changed GatewayObserverApi interface to have default methods #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nginGatewayObserverApiMethodsToDefault
…rApi instead of extending GatewayObserverFactorySpiPrototype.java which doesn't exist anymore
Anisotrop
suggested changes
Mar 31, 2017
There was a problem hiding this comment.
GatewayObserverFactorySpi should be restored and used as an interface not as an abstract class. Also GatewayObserver should not be used as a declared type in constructor signatures and be replaced with GatewayObserverApi. Should also consider logging when injecting a resource fails in the loaded Spi.
| @@ -150,7 +150,7 @@ public void destroyedService(ServiceContext serviceContext) { | |||
|
|
|||
| @Override | |||
| public void startingGateway(GatewayContext gatewayContext) { | |||
| for (GatewayObserverFactorySpi gatewayListenerSpi : gatewayListenerSpi) { | |||
| for (GatewayObserverApi gatewayListenerSpi : gatewayListenerSpi) { | |||
There was a problem hiding this comment.
Should rename the first gatewayListenerSpi into gatewayListener.
…nginGatewayObserverApiMethodsToDefault
Anisotrop
approved these changes
Apr 6, 2017
|
The failed build is caused by: #822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods in
GatewayObserverApinow are default.GatewayObserverFactorySpi&GatewayObserverFactorySpiPrototypeare not needed anymore and have been removed.ManagementGatewayObserverhas been changed to implement the interface.GatewayObserverhas been changed to use the interface instead ofGatewayObserverFactorySpito better adhere to the directive "program to an interface".