Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger error on pako inflate frame failure with inflate status #19

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Trigger error on pako inflate frame failure with inflate status #19

wants to merge 2 commits into from

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Feb 6, 2018 •
edited
Loading

Trigger error on inflating data failure, but still, need works to continue to receive new request gracefully for consecutive requests to works.

See Pako error handling reference:

screen shot 2018-02-06 at 11 02 10 am

@hthetiot hthetiot requested a review from akrambek March 16, 2018 22:33
@hthetiot hthetiot self-assigned this Jul 13, 2018
@hthetiot hthetiot requested review from jitsni and removed request for akrambek and dpwspoon July 13, 2018 01:18
@jitsni jitsni requested a review from dpwspoon July 13, 2018 17:42
@jitsni
Copy link
Contributor

jitsni commented Jul 13, 2018

Looks ok to me.

dpwspoon
dpwspoon approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@dpwspoon dpwspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpwspoon dpwspoon dpwspoon approved these changes

@jitsni jitsni Awaiting requested review from jitsni

Assignees

@hthetiot hthetiot

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hthetiot @jitsni @dpwspoon