[WFLY-18195] Added smallrye reactive messaging in-memory connector #54
Conversation
There was a problem hiding this comment.
@kuhhpid over all this looks good thanks!
One boring thing, is you need to add io.smallrye.reactive:smallrye-reactive-messaging-in-memory to https://github.com/wildfly/wildfly/blob/main/galleon-pack/galleon-shared/src/main/resources/license/licenses.xml#L687. The license will be the same as the other smallrye ones :-)
| </parent> | ||
|
|
||
|
|
||
| <artifactId>wildfly-microprofile-reactive-messaging-inmemory</artifactId> |
There was a problem hiding this comment.
@kuhhpid I don't think we need this module any longer?
| # | ||
|
|
||
| ########################################################################################## | ||
| # Config for InDepthMetadataBean |
There was a problem hiding this comment.
This Javadoc seems a bit out of date. Should probably be InMemoryBean?
| @@ -0,0 +1,90 @@ | |||
| /* | |||
| * JBoss, Home of Professional Open Source. | |||
| * Copyright 2021, Red Hat, Inc., and individual contributors | |||
There was a problem hiding this comment.
Here and other places, this should be 2023 :-)
| @@ -0,0 +1,32 @@ | |||
| <?xml version="1.0" ?> | |||
There was a problem hiding this comment.
Please add a license header like in the file above :-)
| @@ -210,6 +210,14 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <!-- MicroProfile Reactive Messaging In-Memory Connector Test Dependencies --> | |||
There was a problem hiding this comment.
I don't think we need this dependency. Basically, this pom is stuff that needs to be on the compile classpath. And the tests classes don't seem to contain anything from this module.
There was a problem hiding this comment.
In the Test the InMemoryConnector is used which come from smallrye-reactive-messaging-in-memory, so it is needed. Or did I not get the point here?
There was a problem hiding this comment.
Ah, I missed that. In that case I think the test looks a bit strange, in that it is using implementation details :-)
Can you rework it so it uses @Outgoing/@incoming like the Kafka tests do? Generally we should just be using MP Reactive Messaging classes, and not SmallRye ones in user code (i.e the tests)
kuhhpid
force-pushed
the
direct-jar-usage
branch
from
a0a8afa
to
d72529a
Compare
kabir
force-pushed
the
main
branch
7 times, most recently
from
5990738
to
dabfbe3
Compare
kabir
force-pushed
the
main
branch
5 times, most recently
from
f10571c
to
2ed6257
Compare
https://issues.redhat.com/browse/WFLY-18195