Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18195] Added smallrye reactive messaging in-memory connector #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kuhhpid
Copy link

@kuhhpid kuhhpid commented Sep 11, 2023

Copy link
Owner

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuhhpid over all this looks good thanks!

One boring thing, is you need to add io.smallrye.reactive:smallrye-reactive-messaging-in-memory to https://github.com/wildfly/wildfly/blob/main/galleon-pack/galleon-shared/src/main/resources/license/licenses.xml#L687. The license will be the same as the other smallrye ones :-)

</parent>


<artifactId>wildfly-microprofile-reactive-messaging-inmemory</artifactId>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuhhpid I don't think we need this module any longer?

#

##########################################################################################
# Config for InDepthMetadataBean
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Javadoc seems a bit out of date. Should probably be InMemoryBean?

@@ -0,0 +1,90 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2021, Red Hat, Inc., and individual contributors
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and other places, this should be 2023 :-)

@@ -0,0 +1,32 @@
<?xml version="1.0" ?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a license header like in the file above :-)

@@ -210,6 +210,14 @@
<scope>test</scope>
</dependency>

<!-- MicroProfile Reactive Messaging In-Memory Connector Test Dependencies -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this dependency. Basically, this pom is stuff that needs to be on the compile classpath. And the tests classes don't seem to contain anything from this module.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Test the InMemoryConnector is used which come from smallrye-reactive-messaging-in-memory, so it is needed. Or did I not get the point here?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that. In that case I think the test looks a bit strange, in that it is using implementation details :-)

Can you rework it so it uses @Outgoing/@incoming like the Kafka tests do? Generally we should just be using MP Reactive Messaging classes, and not SmallRye ones in user code (i.e the tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants