Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize memory and fine-tuning based on virtual machine spec #36

Merged
merged 6 commits into from
Jul 7, 2024
Merged

Optimize memory and fine-tuning based on virtual machine spec #36

merged 6 commits into from
Jul 7, 2024

Conversation

nhatdongdang
Copy link
Collaborator

  • Tuned kernel size and SIMD align size based on profiling results from the virtual machine.
  • Identified and removed redundant assignment operators.
  • Removed unnecessary padding.
  • Conducted several tests to verify that the changes do not impact existing functionality.

@rozukke rozukke self-requested a review July 7, 2024 04:00
rozukke
rozukke requested changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks

src/main.c Outdated Show resolved Hide resolved
src/matrix.c Show resolved Hide resolved
@kachi-group kachi-group deleted a comment from rozukke Jul 7, 2024
@rozukke rozukke self-requested a review July 7, 2024 05:17
rozukke
rozukke previously approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems like some is unavoidable

@nhatdongdang nhatdongdang requested a review from rozukke July 7, 2024 05:28
rozukke
rozukke approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rozukke rozukke merged commit bc05253 into kachi-group:main Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozukke rozukke rozukke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhatdongdang @rozukke