PDF Generator #23
PDF Generator #23
Conversation
| @@ -0,0 +1,14 @@ | |||
| import * as hbs from "handlebars" | |||
There was a problem hiding this comment.
czy tak nie zadziała?
| import * as hbs from "handlebars" | |
| import hbs from "handlebars" |
There was a problem hiding this comment.
może handlebars będzie jednak lepszą opcja niż skrótowiec, zwłaszcza że użyte jest tylko raz a łatwiej ogarnąć w kodzie że chodzi o handlebars hbs nie wiele mówi :)
| @@ -0,0 +1,14 @@ | |||
| import * as hbs from "handlebars" | |||
| import fs from "fs-extra" | |||
| import * as path from "path" | |||
There was a problem hiding this comment.
czy tak nie zadziała?
| import * as path from "path" | |
| import path from "path" |
| import fs from "fs-extra" | ||
| import * as path from "path" | ||
|
|
||
| const compileHBStoHTML = async (templateName: Handlebars.Template, data: any): Promise<string> => { |
There was a problem hiding this comment.
compiletHandlebarstoHTML, co o tym myślisz?
src/utils/PdfGenerator/PdfPrinter.ts
Outdated
| @@ -0,0 +1,23 @@ | |||
| import * as puppeteer from "puppeteer" | |||
There was a problem hiding this comment.
czy jest jakiś powód dla takiej formy importów? :)
Add Ticket interface
| import path from "path" | ||
| import ITicketData from "./TicketData.inteface"; | ||
|
|
||
| const compileHandlebarsToHTML = async (templateName: Handlebars.Template, data: ITicketData): Promise<string> => { |
There was a problem hiding this comment.
Nazwij plik tak jak nazwa funkcji
| @@ -0,0 +1,23 @@ | |||
| import puppeteer from "puppeteer" | |||
|
|
|||
| const PdfPrinter = async (HTMLToPrint: any): Promise<void> => { | |||
There was a problem hiding this comment.
Nazwa funkcji i pliku z małej litery. Przyjęło się, że pierwsza duża litera jest zarezerwowana dla klas, typów, interfejsów
There was a problem hiding this comment.
I tu stringa przekazujesz, nie any
No description provided.